On Fri, Jul 25, 2025 at 05:41:06PM +0100, Simon Horman wrote:

On Wed, Jul 23, 2025 at 11:01:38PM +0530, Abhijit Gangurde wrote:

quoted

RDMA driver needs to establish admin queues to support admin operations.
Export the APIs to send device commands for the RDMA driver.

Reviewed-by: Shannon Nelson <redacted>
Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>

Hi Abhijit,

Perhaps I misunderstand things, or otherwise am on the wrong track here.
But this seems to open the possibility of users of ionic_adminq_post_wait(),
outside the Ethernet driver, executing a wide range or admin commands.
It seems to me that it would be nice to narrow that surface.

The kernel is monolithic, it is not normal to spend performance
aggressively policing APIs.

mlx5 and other drivers already have interfaces almost exactly like this.

Jason