Re: [PATCH v2 01/15] net: rnpgbe: Add build support for rnpgbe
From: Simon Horman <horms@kernel.org>
Date: 2025-07-22 11:29:15
Also in:
linux-doc, lkml
On Mon, Jul 21, 2025 at 07:32:24PM +0800, Dong Yibo wrote:
Add build options and doc for mucse. Initialize pci device access for MUCSE devices. Signed-off-by: Dong Yibo <dong100@mucse.com>
...
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c new file mode 100644 index 000000000000..13b49875006b --- /dev/null +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c@@ -0,0 +1,226 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2020 - 2025 Mucse Corporation. */ + +#include <linux/types.h> +#include <linux/module.h> +#include <linux/pci.h> +#include <linux/netdevice.h> +#include <linux/string.h> +#include <linux/etherdevice.h> + +#include "rnpgbe.h" + +char rnpgbe_driver_name[] = "rnpgbe";
At least with (only) this patch applied, rnpgbe_driver_name appears to only be used in this file. So it should be static. Flagged by Sparse. Please make sure that when each patch in the series is applied in turn, no new Sparse warnings are introduced. Likewise for build errors. And ideally warnings for W=1 builds. ...