Re: [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c

On Tue, 1 Jul 2025 11:02:50 +0200 Paolo Abeni wrote:

quoted

quoted

I feel a little ambivalent about the removal of the flags arguments.
I understand that they are unused now, but theoretically the operation
as a whole has flags so it's not crazy to pass them along.. Dunno.  

I suspect you can say the same about @gfp. Even though they've both became
irrelevant for the functions that define them. But I understand your
hesitation. Should I post v3 without this/these changes?  

Yes please, I think it would make the series less controversial.

Also I feel like the gfp flag removal is less controversial, as is IMHO
reasonable that skb_splice_from_iter() would not allocate any memory.

+1, FWIW, gfp flags are more as need be the callee.

quoted

What's netdev's stance on using __always_unused in such cases?

Subjectively, I find the unused argument warnings in the kernel
to usually be counter-productive. If a maintainer of a piece of code
wants to clean them up -- perfectly fine. But taking cleanup patches
and annotating with __always_unused doesn't see very productive.