Thread (19 messages) flat view 19 messages, 6 authors, 2025-07-02
STALE401d REVIEWED: 2 (2M)

1 review trailer (1 from subsystem maintainers).

[PATCH net-next v2 3/9] tcp: Drop tcp_splice_state::flags

From: Michal Luczaj <hidden>
Date: 2025-06-26 08:34:30
Also in: linux-rdma, linux-s390, lkml
Subsystem: networking [general], networking [tcp], the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Neal Cardwell, Linus Torvalds

Since skb_splice_bits() does not accept @flags anymore, struct's field
became unused. Remove it.

No functional change indented.

Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Michal Luczaj <redacted>
---
 net/ipv4/tcp.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 46997793d87ab40dcd1e1dd041e4641e287e1b7e..b6285fb1369d32541b9f7d660ca33389b7e4da61 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -324,7 +324,6 @@ EXPORT_IPV6_MOD(tcp_sockets_allocated);
 struct tcp_splice_state {
 	struct pipe_inode_info *pipe;
 	size_t len;
-	unsigned int flags;
 };
 
 /*
@@ -803,7 +802,6 @@ ssize_t tcp_splice_read(struct socket *sock, loff_t *ppos,
 	struct tcp_splice_state tss = {
 		.pipe = pipe,
 		.len = len,
-		.flags = flags,
 	};
 	long timeo;
 	ssize_t spliced;
-- 
2.49.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help