Thread (19 messages) flat view 19 messages, 6 authors, 2025-07-02

Re: [PATCH net-next v2 7/9] net/smc: Drop nr_pages_max initialization

From: Sidraya Jayagond <sidraya@linux.ibm.com>
Date: 2025-06-26 13:26:13
Also in: linux-rdma, linux-s390, lkml


On 26/06/25 2:03 pm, Michal Luczaj wrote:
quoted hunk ↗ jump to hunk
splice_pipe_desc::nr_pages_max was initialized unnecessarily in
commit b8d199451c99 ("net/smc: Allow virtually contiguous sndbufs or RMBs
for SMC-R"). Struct's field is unused in this context.

Remove the assignment. No functional change intended.

Suggested-by: Simon Horman <horms@kernel.org>
Signed-off-by: Michal Luczaj <redacted>
---
  net/smc/smc_rx.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/net/smc/smc_rx.c b/net/smc/smc_rx.c
index e7f1134453ef40dd81a9574d6df4ead95acd8ae5..bbba5d4dc7eb0dbb31a9800023b0caab33e87842 100644
--- a/net/smc/smc_rx.c
+++ b/net/smc/smc_rx.c
@@ -202,7 +202,6 @@ static int smc_rx_splice(struct pipe_inode_info *pipe, char *src, size_t len,
  			offset = 0;
  		}
  	}
-	spd.nr_pages_max = nr_pages;
  	spd.nr_pages = nr_pages;
  	spd.pages = pages;
  	spd.partial = partial;
LGTM.
Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help