Re: [PATCH net-next v13 02/13] net: pse-pd: Add support for reporting events

On Mon, 16 Jun 2025 14:10:12 +0200 Kory Maincent wrote:

psec = pse_control_find_by_id(pcdev, i, &tracker);
rtnl_lock();
if (psec && psec->attached_phydev &&
    psec->attached_phydev->attached_dev)
	ethnl_pse_send_ntf(psec->attached_phydev->attached_dev, notifs,
			   &extack);
rtnl_unlock();
pse_control_put(psec);

You can add another helper for clarity:

pse_control_get_netdev()
{
	ASSERT_RTNL();

	if (!psec || !psec->attached_phydev)
		return NULL
	return psec->attached_phydev->attached_dev;
}

psec = pse_control_find_by_id(pcdev, i, &tracker);
rtnl_lock();
netdev = pse_control_get_netdev(psec);
if (netdev)
	ethnl_pse_send_ntf(netdev, notifs, &extack);
rtnl_unlock();
pse_control_put(psec);

?