Thread (26 messages) 26 messages, 5 authors, 2025-03-31

Re: [PATCH v2 1/4] dt-bindings: net: Add MTIP L2 switch description

From: Lukasz Majewski <lukma@denx.de>
Date: 2025-03-31 07:19:44
Also in: imx, linux-arm-kernel, linux-devicetree, lkml

Hi Krzysztof,
On 30/03/2025 23:04, Lukasz Majewski wrote:
quoted
Hi Krzysztof,
  
quoted
On 29/03/2025 23:10, Lukasz Majewski wrote:  
quoted
quoted
quoted
+      
If this is ethernet switch, why it does not reference
ethernet-switch schema? or dsa.yaml or dsa/ethernet-ports? I am
not sure which one should go here, but surprising to see none.
 
It uses:
$ref:·ethernet-controller.yaml#

for "ports".

Other crucial node is "mdio", which references $ref: mdio.yaml#
 
These are children, I am speaking about this device node.  
It looks like there is no such reference.

I've checked the aforementioned ti,cpsw-switch.yaml,
microchip,lan966x-switch.yaml and
renesas,r8a779f0-ether-switch.yaml.

Those only have $ref: for ethernet-port children node.

The "outer" one doesn't have it.


Or am I missing something?  
There is ethernet-switch.yaml for non-DSA switches and there is DSA
(using ethernet switch, btw). I don't know why these devices do not
use it, I guess no one converted them after we split ethernet-switch
out of DSA.
In net next there is:
Documentation/devicetree/bindings/net/dsa/dsa.yaml
Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml

which uses
$ref: ethernet-switch.yaml#

I will add it in a similar way as it is in dsa.yaml.
Best regards,
Krzysztof



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachments

  • (unnamed) [application/pgp-signature] 488 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help