Hi Krzysztof,

On 29/03/2025 23:10, Lukasz Majewski wrote:

quoted

quoted

quoted

+    

If this is ethernet switch, why it does not reference
ethernet-switch schema? or dsa.yaml or dsa/ethernet-ports? I am
not sure which one should go here, but surprising to see none.  

It uses:
$ref:·ethernet-controller.yaml#

for "ports".

Other crucial node is "mdio", which references $ref: mdio.yaml#  

These are children, I am speaking about this device node.

It looks like there is no such reference.

I've checked the aforementioned ti,cpsw-switch.yaml,
microchip,lan966x-switch.yaml and renesas,r8a779f0-ether-switch.yaml.

Those only have $ref: for ethernet-port children node.

The "outer" one doesn't have it.


Or am I missing something?

quoted

quoted

quoted

+properties:
+  compatible:
+    const: nxp,imx287-mtip--switch    

Just one -.
 

Ok.
  

quoted

quoted

+
+  reg:
+    maxItems: 1
+    description:
+      The physical base address and size of the MTIP L2 SW module
IO range    

Wasn't here, drop.
 

The 'reg' property (reg = <0x800f0000 0x20000>;) is defined in
imx28.dtsi, where the SoC generic properties (as suggested by
Andrew - like clocks, interrupts, clock-names) are moved.  

Drop description, not the reg. Reg was in the previous version. You
added random changes here, not coming from the previous review.

Ach... You mean the "description" in the:

	reg:
	  maxItems: 1
	  description:
	    XX YY

Ok, I will remove it.

Best regards,
Krzysztof

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de