-----Original Message-----
From: Russell King (Oracle) <linux@armlinux.org.uk>
Sent: 12 March 2025 23:27
To: Swathi K S <redacted>
Cc: krzk+dt@kernel.org; andrew+netdev@lunn.ch; davem@davemloft.net;
edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
robh@kernel.org; conor+dt@kernel.org; richardcochran@gmail.com;
mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com;
netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-stm32@st-md-
mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org; pankaj.dubey@samsung.com;
ravi.patel@samsung.com; gost.dev@samsung.com
Subject: Re: [PATCH v8 2/2] net: stmmac: dwc-qos: Add FSD EQoS support

On Wed, Mar 05, 2025 at 02:43:52PM +0000, Russell King (Oracle) wrote:

quoted

On Wed, Mar 05, 2025 at 02:42:46PM +0530, Swathi K S wrote:

quoted

The FSD SoC contains two instance of the Synopsys DWC ethernet QOS IP

core.

quoted

quoted

The binding that it uses is slightly different from existing ones
because of the integration (clocks, resets).

Signed-off-by: Swathi K S <redacted>

This looks much better!

Reviewed-by: Russell King (Oracle) <redacted>

Thanks!

Hi Swathi,

Please can you test with my TX clock gating series applied (
https://lore.kernel.org/r/Z9FVHEf3uUqtKzyt@shell.armlinux.org.uk (local) ) with
STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP set as per the attached diff.
Please let me know whether this passes your testing, so I know whether

this

platform supports it - please check that this results in a message in the

kernel

log indicating "tx_clk_stop = 1". Thanks.

Hi Russell, 
Applied your patches and tested. 
It did not cause any functional issue, but at the same time, as EEE is not
enabled in our HW, we cannot really test that particular functionality.

Regards, 
Swathi

--
RMK's Patch system: https://protect2.fireeye.com/v1/url?k=23e12f6a-
429cc5e9-23e0a425-74fe48600158-954ebfe080aed91e&q=1&e=40e60980-
bcfe-49e0-a9c9-
d9b87765f87c&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2F
patches%2F
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!