-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 06 March 2025 12:35
To: Swathi K S <redacted>; krzk+dt@kernel.org;
andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
conor+dt@kernel.org; richardcochran@gmail.com;
mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
devicetree@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
pankaj.dubey@samsung.com; ravi.patel@samsung.com;
gost.dev@samsung.com
Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
bindings

On 06/03/2025 04:40, Swathi K S wrote:

quoted

quoted

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 05 March 2025 21:12
To: Swathi K S <redacted>; krzk+dt@kernel.org;
andrew+netdev@lunn.ch; davem@davemloft.net;

edumazet@google.com;

quoted

quoted

kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
conor+dt@kernel.org; richardcochran@gmail.com;
mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
devicetree@vger.kernel.org; linux-stm32@st-md-

mailman.stormreply.com;

quoted

quoted

linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
pankaj.dubey@samsung.com; ravi.patel@samsung.com;
gost.dev@samsung.com
Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device
tree bindings

On 05/03/2025 10:12, Swathi K S wrote:

quoted

Add FSD Ethernet compatible in Synopsys dt-bindings document. Add
FSD Ethernet YAML schema to enable the DT validation.

Signed-off-by: Pankaj Dubey <redacted>
Signed-off-by: Ravi Patel <redacted>
Signed-off-by: Swathi K S <redacted>

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you

on the mailing list.

quoted

quoted

Tools like b4 can help here. However, there's no need to repost
patches
*only* to add the tags. The upstream maintainer will do that for tags
received on the version they apply.

Please read:
https://protect2.fireeye.com/v1/url?k=19972162-781c345b-1996aa2d-
000babffae10-7bd6b1a1d78b210b&q=1&e=94dcc3a6-5303-441a-8c1e-
de696b216f86&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.12-
rc3%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting-
patches.rst%23L577

If a tag was not added on purpose, please state why and what changed.

Hi Krzysztof,
As per a review comment received from Russell, I had added 2 new

properties to the DT - assigned-clocks and assigned-clock-parents properties.

quoted

The example in the DT binding reflects the same.
I felt it wouldn't be fair to add 'Reviewed-by' tag without you reviewing the

updates again.

quoted

But I should have mentioned that in cover letter and apologies for missing

to do that.
Nothing in changelog explained new properties. Nothing mentioned

Had mentioned under 'changes since v7' in the cover letter patch where I had mentioned about addressing Russell's comment and corresponding DT binding example changes of setting clock tree in DT.

- Swathi 

dropping tag, which you always must explicitly say.

Best regards,
Krzysztof