Dear Christophe,

Thank you for reviewing,

Christophe JAILLET [off-list ref] 於 2025年2月8日 週六 上午3:06寫道：

Le 07/02/2025 à 08:44, Ming Yu a écrit :

quoted

This driver supports I2C adapter functionality for NCT6694 MFD
device based on USB interface, each I2C controller use default
baudrate(100K).

...

quoted

+static int nct6694_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
+{
+     struct nct6694_i2c_data *data = adap->algo_data;
+     struct nct6694_i2c_deliver *deliver = &data->deliver;
+     static const struct nct6694_cmd_header cmd_hd = {
+             .mod = NCT6694_I2C_MOD,
+             .cmd = NCT6694_I2C_DELIVER,
+             .sel = NCT6694_I2C_DELIVER_SEL,
+             .len = cpu_to_le16(sizeof(*deliver))
+     };
+     int ret, i;
+
+     for (i = 0; i < num ; i++) {

Tiny tiny nitpick: unneeded extra space after num

Okay, I will fix it in the next patch.


Best regards,
Ming