Dear Christophe,

Thank you for reviewing,

Christophe JAILLET [off-list ref] 於 2025年2月8日 週六 上午2:37寫道：

Le 07/02/2025 à 08:44, Ming Yu a écrit :

quoted

The Nuvoton NCT6694 is a peripheral expander with 16 GPIO chips,
6 I2C controllers, 2 CANfd controllers, 2 Watchdog timers, ADC,
PWM, and RTC.

This driver implements USB device functionality and shares the
chip's peripherals as a child device.

Each child device can use the USB functions nct6694_read_msg()
and nct6694_write_msg() to issue a command. They can also request
interrupt that will be called when the USB device receives its
interrupt pipe.

...

quoted

+static struct irq_chip nct6694_irq_chip = {

This could be const.

(I'm working on a serie that should constify struct irq_chip, so this
one would already be done)

Okay, I will fix it in the next patch.


Best regards,
Ming