Thread (29 messages) 29 messages, 4 authors, 2025-01-22

回覆: 回覆: 回覆: 回覆: 回覆: [PATCH v2 05/10] ARM: dts: aspeed: system1: Add RGMII support

From: Jacky Chou <jacky_chou@aspeedtech.com>
Date: 2025-01-15 04:22:21
Also in: linux-arm-kernel, linux-aspeed, linux-devicetree, lkml

Hi Andrew
quoted
Perhaps we will keep using "rgmii"
No. It is wrong.
quoted
The reason is we cannot be sure all PHYs have support for phy-mode
property.
quoted
We will refer to the other MACs and PHYs driver about phy-mode and
rx/tx-internal-delay-ps properties how they implement.

Currently, we will plan to implement RGMII delay in ftgmac100 driver
based on ethernet-controller.yaml.

At same time, we will think how to configure these phy-mode "rgmii-rxid",
"rgmii-txid"
quoted
and "rgmii-id in MAC driver.
I already explain how this works once. Please read this thread again.... The
MAC can apply the delays, but it must mask the phy-mode it passes to the PHY.
Yes. I have read these mails.

I understand what you mean.
"rgmii": delay on PCB, not MAC or PHY.
"rgmii-id": delay on MAC or PHY, not PCB.

ftgmac100 driver gets phy driver handle from of_phy_get_and_connect(), it will pass the phy-mode to
phy driver from the node of mac dts.
Therefore, I use "rgmii-id" and the phy will enable tx/rx internal delay.
If I use "rgmii-id" and configure the RGMII delay in ftgmac100 driver, I cannot pass the phy-mode to 
phy driver.
May I be correct?

Based on ethernel-controller.yaml, maybe need to adjust the description about phy-mode in this file first?

Thanks,
Jacky
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help