Thread (29 messages) 29 messages, 4 authors, 2025-01-22

Re: 回覆: 回覆: 回覆: 回覆: [PATCH v2 05/10] ARM: dts: aspeed: system1: Add RGMII support

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-01-15 03:06:00
Also in: linux-arm-kernel, linux-aspeed, linux-devicetree, lkml

On Wed, Jan 15, 2025 at 02:57:04AM +0000, Jacky Chou wrote:
Hi Andrew and Ninad,
quoted
quoted
Thanks. What will be the "phy-mode" value after you make these changes?

Will it be "rgmii-id" for MAC1..4?
It should be.
Perhaps we will keep using "rgmii"
No. It is wrong.
The reason is we cannot be sure all PHYs have support for phy-mode property.
We will refer to the other MACs and PHYs driver about phy-mode and 
rx/tx-internal-delay-ps properties how they implement.

Currently, we will plan to implement RGMII delay in ftgmac100 driver based on
ethernet-controller.yaml.

At same time, we will think how to configure these phy-mode "rgmii-rxid", "rgmii-txid" 
and "rgmii-id in MAC driver.
I already explain how this works once. Please read this thread
again.... The MAC can apply the delays, but it must mask the phy-mode
it passes to the PHY.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help