Thread (29 messages) 29 messages, 4 authors, 2025-01-22

回覆: [PATCH v2 05/10] ARM: dts: aspeed: system1: Add RGMII support

From: Jacky Chou <jacky_chou@aspeedtech.com>
Date: 2025-01-09 10:33:24
Also in: linux-arm-kernel, linux-aspeed, linux-devicetree, lkml

Hi Andrew,
quoted
There are around 11 boards in Aspeed SOC with phy-mode set to "rgmii"
(some of them are mac0&1 and others are mac2&3). "rgmii-rxid" is only
mine.
quoted
No one in aspeed SOC using "rgmii-id".
O.K, so we have to be careful how we fix this. But the fact they are all equally
broken might help here.
quoted
quoted
Humm, interesting. Looking at ftgmac100.c, i don't see where you
configure the RGMII delays in the MAC?
This is going to be important. How are delays configured if they are not in the
MAC driver?
The RGMII delay is adjusted on clk-ast2600 driver. Please refer to the following link.
https://github.com/AspeedTech-BMC/linux/blob/f52a0cf7c475dc576482db46759e2d854c1f36e4/drivers/clk/clk-ast2600.c#L1008

We recently plan to upstream to mainline this part about the RGMII delay configuration.
All MAC RGMII delay of ast2600 are configured on the SCU register.
As mentioned before, we would like to configure the RGMII TX/RX delay on BMC side.
Therefore, we use the "rgmii" and "rgmii-rxid" as the recommendation for our design.

Thanks,
Jacky
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help