From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, 30 January 2025 3:17
To: Danielle Ratson <redacted>
Cc: netdev@vger.kernel.org; mkubecek@suse.cz; matt@traverse.com.au;
daniel.zahka@gmail.com; Amit Cohen [off-list ref]; NBU-mlxsw
[off-list ref]
Subject: Re: [PATCH ethtool-next 08/14] cmis: Enable JSON output support in
CMIS modules

On Wed, 29 Jan 2025 07:06:09 +0000 Danielle Ratson wrote:

quoted

quoted

Is the consumer of the JSON output supposed to be parsing the units
and making sure to scale the values every time it reads (e.g. divide
by 1000 if it wants W but unit is mW)?

Or the unit is fully implied by the key, and can't change? IOW the
unit is only listed so that the human writing the consumer can
figure out the unit and then hardcode it?

Yes, the unit is implied by the key is hardcoded. Same as for the
regular output, it should give the costumer idea about the scale.
There are also temperature fields that could be either F or C degrees.
So overall , the units fields should align all the fields that implies
some sort of scale.

Some sort of a schema would be a better place to document the unit of the
fields, IMO.

So should the units fields be removed entirely?  And only be documented in the json schema file?