Thread (39 messages) 39 messages, 6 authors, 2025-02-03

Re: [PATCH ethtool-next 08/14] cmis: Enable JSON output support in CMIS modules

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-01-27 20:12:59

On Sun, 26 Jan 2025 13:56:29 +0200 Danielle Ratson wrote:
       "tx_loss_of_signal": "None",
        "rx_loss_of_lock": "None",
        "tx_loss_of_lock": "None",
        "tx_fault": "None",
Why "None" in this case rather than true/false/null ?
        "module_state": 3,
        "module_state_description": "ModuleReady",
        "low_pwr_allow_request_hw": false,
        "low_pwr_request_sw": false,
        "module_temperature": 36.8203,
        "module_temperature_units": "degrees C",
        "module_voltage": 3.3385,
        "module_voltage_units": "V",
        "laser_tx_bias_current": [
0.0000,0.0000,0.0000,0.0000,0.0000,0.0000,0.0000,0.0000 ],
        "laser_tx_bias_current_units": "mA",
How do you think about the units?
If they may differ module to module - should we aim to normalize those?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help