Thread (39 messages) 39 messages, 6 authors, 2025-02-03

Re: [PATCH ethtool-next 09/14] qsfp: Add JSON output handling to --module-info in SFF8636 modules

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-01-27 20:16:07

On Sun, 26 Jan 2025 13:56:30 +0200 Danielle Ratson wrote:
+		open_json_object("extended_identifier");
+		print_int(PRINT_JSON, "value", "0x%02x",
+			  map->page_00h[SFF8636_EXT_ID_OFFSET]);
Hm, why hex here?
Priority for JSON output is to make it easy to handle in code,
rather than easy to read. Hex strings need extra manual decoding, no?

BTW thanks for pushing this work forward!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help