Re: [PATCH net v2 2/6] vsock: Allow retrying on connect() failure
From: Luigi Leonardi <hidden>
Date: 2025-01-22 16:28:15
On Tue, Jan 21, 2025 at 03:44:03PM +0100, Michal Luczaj wrote:
quoted hunk ↗ jump to hunk
sk_err is set when a (connectible) connect() fails. Effectively, this makes an otherwise still healthy SS_UNCONNECTED socket impossible to use for any subsequent connection attempts. Clear sk_err upon trying to establish a connection. Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Signed-off-by: Michal Luczaj <redacted> --- net/vmw_vsock/af_vsock.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index cfe18bc8fdbe7ced073c6b3644d635fdbfa02610..075695173648d3a4ecbd04e908130efdbb393b41 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c@@ -1523,6 +1523,11 @@ static int vsock_connect(struct socket *sock, struct sockaddr *addr,if (err < 0) goto out; + /* sk_err might have been set as a result of an earlier + * (failed) connect attempt. + */ + sk->sk_err = 0;
Just to understand: Why do you reset sk_error after calling to transport->connect and not before? My worry is that a transport might check this field and return an error. IIUC with virtio-based transports this is not the case.
+ /* Mark sock as connecting and set the error code to in * progress in case this is a non-blocking connect. */ -- 2.48.1
Thanks, Luigi