Thread (24 messages) 24 messages, 4 authors, 2025-01-28

Re: [PATCH net v2 0/6] vsock: Transport reassignment and error handling issues

From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2025-01-22 11:45:27

On Tue, Jan 21, 2025 at 03:44:01PM +0100, Michal Luczaj wrote:
Series deals with two issues:
- socket reference count imbalance due to an unforgiving transport release
 (triggered by transport reassignment);
- unintentional API feature, a failing connect() making the socket
 impossible to use for any subsequent connect() attempts.

Signed-off-by: Michal Luczaj <redacted>
---
Changes in v2:
- Introduce vsock_connect_fd(), simplify the tests, stick to SOCK_STREAM,
 collect Reviewed-by (Stefano)
- Link to v1: https://lore.kernel.org/r/20250117-vsock-transport-vs-autobind-v1-0-c802c803762d@rbox.co (local)
Thanks for sorting out my comments, I've reviewed it all and got it
running, it seems to be going well!

Stefano
---
Michal Luczaj (6):
     vsock: Keep the binding until socket destruction
     vsock: Allow retrying on connect() failure
     vsock/test: Introduce vsock_bind()
     vsock/test: Introduce vsock_connect_fd()
     vsock/test: Add test for UAF due to socket unbinding
     vsock/test: Add test for connect() retries

net/vmw_vsock/af_vsock.c         |  13 ++++-
tools/testing/vsock/util.c       |  87 +++++++++++-----------------
tools/testing/vsock/util.h       |   2 +
tools/testing/vsock/vsock_test.c | 122 ++++++++++++++++++++++++++++++++++-----
4 files changed, 152 insertions(+), 72 deletions(-)
---
base-commit: d640627663bfe7d8963c7615316d7d4ef60f3b0b
change-id: 20250116-vsock-transport-vs-autobind-2da49f1d5a0a

Best regards,
-- 
Michal Luczaj [off-list ref]
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help