On 1/22/25 12:45, Stefano Garzarella wrote:

On Tue, Jan 21, 2025 at 03:44:01PM +0100, Michal Luczaj wrote:

quoted

Series deals with two issues:
- socket reference count imbalance due to an unforgiving transport release
 (triggered by transport reassignment);
- unintentional API feature, a failing connect() making the socket
 impossible to use for any subsequent connect() attempts.

Signed-off-by: Michal Luczaj <redacted>
---
Changes in v2:
- Introduce vsock_connect_fd(), simplify the tests, stick to SOCK_STREAM,
 collect Reviewed-by (Stefano)
- Link to v1: https://lore.kernel.org/r/20250117-vsock-transport-vs-autobind-v1-0-c802c803762d@rbox.co (local)

Thanks for sorting out my comments, I've reviewed it all and got it
running, it seems to be going well!

Great! I was worried that I might have oversimplified the UAF selftest
(won't trigger the splat if second transport == NULL), so please let me
know if it starts acting strangely (quietly passes the test on an unpatched
system), and for what combination of enabled transports.

Thanks,
Michal