Thread (39 messages) 39 messages, 12 authors, 2024-12-26

Re: [PATCH v3 3/7] i2c: Add Nuvoton NCT6694 I2C support

From: Andi Shyti <andi.shyti@kernel.org>
Date: 2024-12-26 09:25:51
Also in: linux-can, linux-gpio, linux-hwmon, linux-i2c, linux-rtc, linux-watchdog, lkml

Hi Ming,
quoted
quoted
+static struct platform_driver nct6694_i2c_driver = {
+     .driver = {
+             .name   = "nct6694-i2c",
+     },
+     .probe          = nct6694_i2c_probe,
+     .remove         = nct6694_i2c_remove,
+};
+
+module_platform_driver(nct6694_i2c_driver);
what I meant in v1 is to try using module_auxiliary_driver().
Check, e.g., i2c-ljca.c or i2c-keba.c.
I think the NCT6694  is an MCU-based device, and the current
implementation is as an MFD driver. Are you suggesting it should
instead be implemented as an auxiliary device driver? If so, would
that mean all related drivers need to be revised accordingly?
No worries, module_platform_driver() is also fine.

Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help