Dear Linus,

Thank you for your reply,

Linus Walleij [off-list ref] 於 2024年12月20日 週五 下午8:45寫道：

Hi Ming,

thanks for your patch!

...

quoted

+       while (*int_status) {
+               int irq = __ffs(*int_status);
+
+               if (*int_status & (1 << irq))
+                       generic_handle_irq_safe(irq_find_mapping(nct6694->domain, irq));
+
+               *int_status &= ~(1 << irq);

What about doing what you do in the GPIO driver and
#include <linux/bits.h>

And search and replace "(1 << irq)" with BIT(irq)?

PS the main reason we do this is because

int a = (1 << 31);

becomes a negative number on 32bit machines, and
can lead to confusing side effects. BIT() always work
on unsigned.

Understood! I will make the modifications in the v4.

Best regards,
Ming