Dear Vincent,

Thank you for your comments,
I understand, I will make the modifications for these drivers,

Thanks,
Ming

Vincent Mailhol [off-list ref] 於 2024年12月13日 週五 上午12:10寫道：

...

quoted

+struct nct6694_hwmon_data {
+       struct nct6694 *nct6694;
+       struct mutex lock;
+       unsigned char *xmit_buf;
+       unsigned char hwmon_en[NCT6694_HWMON_CMD0_LEN];
+};

A global comment on this series: do not declare your buffers as some
opaque unsigned char arrays. Instead, make it a structure (or an array
of structures if needed) using the little endian types for the
different fields.

You already applied this change to the CAN driver after I made a
comment, please do the same throughout the series.

The same applies with any other comments made by anyone else: do not
only apply to the patch where the comment is made, but apply it
broadly to the series.

Thank you.


Yours sincerely,
Vincent Mailhol