On Tue, 17 Dec 2024 06:49:07 -0800
Jakub Kicinski [off-list ref] wrote:
Let me triple check ;)
On Tue, 17 Dec 2024 13:59:32 +0100 Maxime Chevallier wrote:
quoted
- The priv->phylink_config.supported_interfaces is incomplete on
dwmac-socfpga. Russell's patch 5 intersects these modes with that the
^^^^^^^^^^
quoted
PCS supports :
+ phy_interface_or(priv->phylink_config.supported_interfaces,
^^
quoted
+ priv->phylink_config.supported_interfaces,
+ pcs->supported_interfaces);
So without patch 2 in the series, we'll be missing
PHY_INTERFACE_MODE_1000BASEX in the end result :)
"Or" is a sum/union, not intersection.
You set the bits in priv->phylink_config.supported_interfaces.
Russell does:
priv->phylink_config.supported_interfaces |=
pcs->supported_interfaces;
If I'm missing the point please repost once Russell's patches
are merged :)
Erf no I was missing the point, time to catch-up on some sleep I
guess... I read an 'and' and it was firmly stuck in my mind...
nevermind then, patch 2 isn't required anymore...
Maxime