Hi Russell,
On Fri, 13 Dec 2024 19:35:01 +0000
"Russell King (Oracle)" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Fill in the new PCS supported_interfaces member with the interfaces
that the Mediatek LynxI supports.
Signed-off-by: Russell King (Oracle) <redacted>
---
drivers/net/pcs/pcs-mtk-lynxi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
index 7de804535229..1377fb78eaa1 100644
--- a/drivers/net/pcs/pcs-mtk-lynxi.c
+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
@@ -306,6 +306,11 @@ struct phylink_pcs *mtk_pcs_lynxi_create(struct device *dev,
mpcs->pcs.poll = true;
mpcs->interface = PHY_INTERFACE_MODE_NA;
+ __set_bit(PHY_INTERFACE_MODE_SGMII, mpcs->pcs.supported_interfaces);
+ __set_bit(PHY_INTERFACE_MODE_QSGMII, mpcs->pcs.supported_interfaces);
I'm sorry if I missed something, but I don't find where the QSGMII
support comes from based on the current codebase :/
I didn't spot that in the inband_caps commit, sorry :(
+ __set_bit(PHY_INTERFACE_MODE_1000BASEX, mpcs->pcs.supported_interfaces);
+ __set_bit(PHY_INTERFACE_MODE_2500BASEX, mpcs->pcs.supported_interfaces);
Thanks,
Maxime