Re: [PATCH v3 5/5] wifi: brcmfmac: Add support for AP6275P
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Date: 2024-06-30 11:17:45
Also in:
linux-arm-kernel, linux-devicetree, linux-rockchip, linux-wireless, lkml
On June 30, 2024 9:36:40 AM Jacobe Zang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This module features BCM43752A2 chipset. The firmware requires randomness seeding, so enabled it. Co-developed-by: Ondrej Jirman <megi@xff.cz> Signed-off-by: Ondrej Jirman <megi@xff.cz> Signed-off-by: Jacobe Zang <redacted> Link: https://megous.com/git/linux/commit/?h=ap6275p-6.10&id=1a99573bc8ed412e60e1969c0b29d53a0e5782e0 --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 5 ++++- .../net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-)diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.cb/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index e84f562fc91b8..f427d664cf3a5 100644--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
[...]
quoted hunk ↗ jump to hunk
@@ -1721,7 +1723,7 @@ static int brcmf_pcie_download_fw_nvram(structbrcmf_pciedev_info *devinfo, memcpy_toio(devinfo->tcm + address, nvram, nvram_len); brcmf_fw_nvram_free(nvram); - if (devinfo->otp.valid) { + if (devinfo->otp.valid || devinfo->ci->chip
So the problem here is that otp validity is not unambiguous. The seed requirement is mandated by firmware and was introduced for new WCC chips moving forward. I would suggest to have a need_seed flag in the driver_data of the device table (below). It currently is used only for vendor identification. Regards, Arend
quoted hunk ↗ jump to hunk
== BRCM_CC_43752_CHIP_ID) { size_t rand_len = BRCMF_RANDOM_SEED_LENGTH; struct brcmf_random_seed_footer footer = { .length = cpu_to_le32(rand_len),@@ -2710,6 +2712,7 @@ static const struct pci_device_idbrcmf_pcie_devid_table[] = { BRCMF_PCIE_DEVICE(BRCM_PCIE_4366_5G_DEVICE_ID, BCA), BRCMF_PCIE_DEVICE(BRCM_PCIE_4371_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_43596_DEVICE_ID, CYW), + BRCMF_PCIE_DEVICE(BRCM_PCIE_43752_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_4377_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_4378_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_4387_DEVICE_ID, WCC),
Attachments
- smime.p7s [application/pkcs7-signature] 4219 bytes