Thread (15 messages) 15 messages, 5 authors, 2024-05-29

Re: [PATCH v4] ax25: Fix refcount imbalance on inbound connections

From: <hidden>
Date: 2024-05-29 15:02:19
Also in: linux-hams

On Wed, 29 May 2024 17:34:20 +0300 Dan Carpenter wrote:
1) The Fixes tag points to the wrong commit, though, right?  The one
you have here doesn't make sense and it doesn't match the bisect.
I also have tested Lars Kellogg-Stedman`s patch, it works well. I think the Fixes 
tag shoud be 9fd75b66b8f6 ("ax25: Fix refcount leaks caused by ax25_cb_del()").
2) Can we edit the commitmessage a bit to say include what you wrote
about "but rather bind/accept" being paired.  We increment in bind
and we should increment in accept as well.  It's the same.

3) The other thing that I notice is that Duoming dropped part of his
commit when he resent v6.
https://lore.kernel.org/all/5c61fea1b20f3c1596e4fb46282c3dedc54513a3.1715065005.git.duoming@zju.edu.cn/ (local)
That part of the commit was correct.  Maybe it wasn't necessary but it
feels right and it's more readable and it's obviously harmless.  I can
resend that.
I will resend it latter.

Best regards,
Duoming Zhou
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help