Re: [PATCH v4] ax25: Fix refcount imbalance on inbound connections
From: Lars Kellogg-Stedman <hidden>
Date: 2024-05-29 14:54:47
Also in:
linux-hams
From: Lars Kellogg-Stedman <hidden>
Date: 2024-05-29 14:54:47
Also in:
linux-hams
On Wed, May 29, 2024 at 05:34:20PM GMT, Dan Carpenter wrote:
1) The Fixes tag points to the wrong commit, though, right? The one you have here doesn't make sense and it doesn't match the bisect.
I'll double check that; thanks for checking.
2) Can we edit the commitmessage a bit to say include what you wrote about "but rather bind/accept" being paired. We increment in bind and we should increment in accept as well. It's the same.
I'll update the wording.
3) The other thing that I notice is that Duoming dropped part of his commit when he resent v6. https://lore.kernel.org/all/5c61fea1b20f3c1596e4fb46282c3dedc54513a3.1715065005.git.duoming@zju.edu.cn/ (local) That part of the commit was correct. Maybe it wasn't necessary but it feels right and it's more readable and it's obviously harmless. I can resend that.
Just so that I'm clear, with that comment you're not suggesting any
changes to my patch, right?
--
Lars Kellogg-Stedman [off-list ref] | larsks @ {irc,twitter,github}
http://blog.oddbit.com/ | N1LKS