On Fri, May 24, 2024 at 11:25:36AM -0400, Lars Kellogg-Stedman wrote:

On Thu, May 23, 2024 at 04:39:27PM GMT, Dan Cross wrote:

quoted

On Thu, May 23, 2024 at 2:23 PM Dan Carpenter [off-list ref] wrote:

quoted

The problem is that accept() and ax25_release() are not mirrored pairs.

Right, but my in making this patch I wasn't thinking so much about
accept/ax25_release, which as you say are not necessarily a mirrored
pair...

quoted

It seems clear that this will happen for sockets that have a ref on
the device either via `bind` or via `accept`.

...but rather bind/accept, which *are*. The patch I've submitted gives
us equivalent behavior on the code paths for inbound and outbound
connections.

This is the explanation I was looking for.  Sorry, I meant to review
these patches again over the weekend but I got caught up in other things.
Give me until tomorrow to review it again.

regards,
dan carpenter