RE: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend

From: Michael Chan <michael.chan@broadcom.com>
Sent: Wednesday, March 27, 2024 10:39 AM
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ratheesh Kannoth <rkannoth@marvell.com>; Nikita Kiryushin
[off-list ref]; Michael Chan [off-list ref]; Pavan
Chebbi [off-list ref]; David S. Miller
[off-list ref]; Eric Dumazet [off-list ref]; Paolo
Abeni [off-list ref]; Rafael J. Wysocki [off-list ref];
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; lvc-
project@linuxtesting.org
Subject: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error
handling in tg3_suspend

Prioritize security for external emails: Confirm sender and content safety
before clicking links or opening attachments

----------------------------------------------------------------------
On Tue, Mar 26, 2024 at 8:24 PM Jakub Kicinski [off-list ref] wrote:

quoted

On Wed, 27 Mar 2024 08:14:30 +0530 Ratheesh Kannoth wrote:

quoted

quoted

@@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device

*device)

quoted

quoted

quoted

 {

Please address Michael Chan's comment to make this function return type

to "void"

quoted

quoted

instead of "int"

It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work?

It won't work.  I only requested to change tg3_power_down_prepare() to
void and it was done in v2:

https://lore.kernel.org/netdev/CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZk
GaC9jfvFXrQ@mail.gmail.com/

Got it. Thanks.