Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend

As of now, tg3_power_down_prepare always ends with success, but
the error handling code from former tg3_set_power_state call is still here.

Remove (now unreachable) code for simplification and change
tg3_power_down_prepare to a void function as its result is no more checked.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: c866b7eac073 ("tg3: Do not use legacy PCI power management")
Signed-off-by: Nikita Kiryushin <redacted>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
---
v2: Change tg3_power_down_prepare() to a void function
as Michael Chan [off-list ref] suggested.
 drivers/net/ethernet/broadcom/tg3.c | 30 ++++-------------------------
 1 file changed, 4 insertions(+), 26 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 04964bbe08cf..bc36926a57cf 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c

@@ -4019,7 +4019,7 @@ static int tg3_power_up(struct tg3 *tp)

 static int tg3_setup_phy(struct tg3 *, bool);

-static int tg3_power_down_prepare(struct tg3 *tp)
+static void tg3_power_down_prepare(struct tg3 *tp)
 {
 	u32 misc_host_ctrl;
 	bool device_should_wake, do_low_power;

@@ -4263,7 +4263,7 @@ static int tg3_power_down_prepare(struct tg3 *tp)

 	tg3_ape_driver_state_change(tp, RESET_KIND_SHUTDOWN);

-	return 0;
+	return;
 }

 static void tg3_power_down(struct tg3 *tp)

@@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device *device)
 {