Re: [PATCH v2] tg3: Remove residual error handling in tg3_suspend

On Mon, Mar 11, 2024 at 8:45 AM Nikita Kiryushin [off-list ref] wrote:

As of now, tg3_power_down_prepare always ends with success, but
the error handling code from former tg3_set_power_state call is still here.

Remove (now unreachable) code for simplification and change
tg3_power_down_prepare to a void function as its result is no more checked.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: c866b7eac073 ("tg3: Do not use legacy PCI power management")
Signed-off-by: Nikita Kiryushin <redacted>
---
v2: Change tg3_power_down_prepare() to a void function
as Michael Chan [off-list ref] suggested.
  drivers/net/ethernet/broadcom/tg3.c | 30 ++++-------------------------
  1 file changed, 4 insertions(+), 26 deletions(-)

The patch looks good to me.  But this cleanup patch should be for
net-next and net-next is closed right now.
Please re-post in about 2 weeks.  You can add my tag when you repost:

Reviewed-by: Michael Chan <michael.chan@broadcom.com>

Thanks.