Re: [PATCH 1/3] arm64: dts: S32G3: Introduce device tree for S32G-VNP-RDB3
From: Krzysztof Kozlowski <hidden>
Date: 2024-03-18 09:57:39
Also in:
linux-arm-kernel, linux-clk, linux-devicetree, lkml
On 18/03/2024 10:34, Wadim Mueller wrote:
On Mon, Mar 18, 2024 at 09:32:24AM +0200, Ghennadi Procopciuc wrote:quoted
On 3/16/24 00:27, Wadim Mueller wrote:quoted
This commit adds device tree support for the NXP S32G3-based S32G-VNP-RDB3 Board (Vehicle Networking Platform - Reference Design Board) [1]. The S32G3 features an 8-core ARM Cortex-A53 based SoC developed by NXP. The device tree files are derived from the official NXP downstream Linux tree [2]. This addition encompasses a limited selection of peripherals that are upstream-supported. Apart from the ARM System Modules (GIC, Generic Timer, etc.), the following IPs have been validated: UART: fsl-linflexuart SDHC: fsl-imx-esdhc Ethernet: synopsys gmac/stmac Clock settings for the chip rely on ATF Firmware [3]. Pin control integration into the device tree is pending and currently relies on Firmware/U-Boot settings [4]. These changes were validated using the latest BSP39 Firmware/U-Boot from NXP [5]. The modifications enable booting the official Ubuntu 22.04 from NXP on the RDB3 with default settings from the SD card and eMMC. [1] https://www.nxp.com/design/design-center/designs/s32g3-vehicle-networking-reference-design:S32G-VNP-RDB3 [2] https://github.com/nxp-auto-linux/linux [3] https://github.com/nxp-auto-linux/arm-trusted-firmware [4] https://github.com/nxp-auto-linux/u-boot [5] https://github.com/nxp-auto-linux/auto_yocto_bsp Signed-off-by: Wadim Mueller <redacted>This patch seems to be heavily based on the downstream version of the kernel. Many of the changes originate from NXP. Therefore, shouldn't the authors also be mentioned here?Yes, it definitely is, I also mentionaed it in the commit message. As Krzyszof mentioned, would you expect me to "git blame" the file and put all contributors into the commment part? Or would it be enough to put a Copyright of NXP as here [1]? [1] https://github.com/nxp-auto-linux/linux/blob/cdac0506874b7e6a277f12e72e3900d2a410d909/arch/arm64/boot/dts/freescale/s32g3.dtsi#L3
This has copyright from 2021, so 3 years is enough for NXP to prove they care and upstream it. If they don't do it within 3 years, it is proof NXP does not care enough, so I don't think you need to provide any authorship remarks. Especially that many emails might be incorrect. Your Cc-list here already creates 4 bounces.. But keep the copyright if you indeed based on that file. Best regards, Krzysztof