Thread (90 messages) 90 messages, 8 authors, 2024-04-02

Re: [PATCH net-next v2 04/22] ovpn: add basic interface creation/destruction/management routines

From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-03-08 13:13:05

To be honest we don't have any real concept for the carrier off.
Especially on a server, I hardly believe it would be any useful.

However, on a client or on a p2p link, where there is exactly one remote
host on the other side, it may make sense to turn the carrier off when that
remote peer is lost.

There is an extra detail to consider: if the user wants to, the ovpn device
should remain configured (with all IPs and routes) even if openvpn has fully
disconnected and it is attempting a reconnection to another server. Reason
being avoiding data leaks by accidentally removing routes to the tunnel
(traffic that should go through the tunnel would rather go to the local
network).

With all this being said, it may make sense to just keep the carrier on all
time long.

Should we come up with something smarter in the future, we can still improve
this behaviour.
O.K, so..

You already have more patches than recommended for a series, but... I
suggest you make the carrier_on in probe() a patch of its own with a
good commit message based on the above. We then have a clear
explanation in git why the carrier is always on.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help