Re: [PATCH net-next v2 03/22] ovpn: add basic netlink support
From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-03-06 19:09:58
quoted
quoted
Right, so this in general makes sense. The only question i have now is, should you be using rtnl_link_stats64. That is the standard structure for interface statistics.@Andrew: do you see how I could return/send this object per-peer to userspace? I think the whole interface stats logic is based on the one-stats-per-device concept. Hence, I thought it was meaningful to just send my own stats via netlink.
Ah, interesting. I never looked at the details for rtnl_link_stats64. It is buried in the middle of ifinfo. So not very reusable :-( Idea #2: A peer is not that different to an interface queue. Jakub recently posted some code for that: https://lwn.net/ml/netdev/20240229010221.2408413-2-kuba@kernel.org/ Maybe there are ideas you can borrow from there. But lets look at this from another direction. What are the use cases for these statistics? Does the userspace daemon need them, e.g. to detect a peer which is idle and should be disconnected? Are they exported via an SNMP MIB? Andrew