Thread (90 messages) 90 messages, 8 authors, 2024-04-02

Re: [PATCH net-next v2 04/22] ovpn: add basic interface creation/destruction/management routines

From: Antonio Quartulli <antonio@openvpn.net>
Date: 2024-03-06 14:59:09

On 05/03/2024 20:40, Jakub Kicinski wrote:
On Mon,  4 Mar 2024 16:08:55 +0100 Antonio Quartulli wrote:
quoted
+	dev = alloc_netdev(sizeof(struct ovpn_struct), name, NET_NAME_USER, ovpn_setup);
+
+	dev_net_set(dev, net);
the dev allocation never fails? Or the error is handles somewhere else?
It definitely can fail and dev_net_set will crash.
My bad. Thanks for reporting this.


Regards,

-- 
Antonio Quartulli
OpenVPN Inc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help