Thread (52 messages) 52 messages, 8 authors, 2024-04-02

Re: [PATCH net-next v5 13/21] bitmap: make bitmap_{get,set}_value8() use bitmap_{read,write}()

From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date: 2024-02-02 11:39:24
Also in: intel-wired-lan, linux-btrfs, linux-s390, lkml, ntfs3

On 2/1/24 13:22, Alexander Lobakin wrote:
Now that we have generic bitmap_read() and bitmap_write(), which are
inline and try to take care of non-bound-crossing and aligned cases
to keep them optimized, collapse bitmap_{get,set}_value8() into
simple wrappers around the former ones.
bloat-o-meter shows no difference in vmlinux and -2 bytes for
gpio-pca953x.ko, which says the optimization didn't suffer due to
that change. The converted helpers have the value width embedded
and always compile-time constant and that helps a lot.

Suggested-by: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
---
  include/linux/bitmap.h | 38 +++++---------------------------------
  1 file changed, 5 insertions(+), 33 deletions(-)
Hah, nice!
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help