Thread (73 messages) 73 messages, 9 authors, 2024-04-08

Re: [PATCH net-next v2 0/9] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface

From: <Parthiban.Veerasooran@microchip.com>
Date: 2024-02-21 05:15:27

On 19/02/24 8:00 pm, Andrew Lunn wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
quoted
Hi Andrew,

  From Microchip side, we haven't stopped/postponed this framework
development. We are already working on it. It is in the final stage now.
We are doing internal reviews right now and we expect that in 3 weeks
time frame in the mainline again. We will send a new version (v3) of
this patch series soon.
Hi Parthiban

It is good to here you are still working on it.

A have a few comments about how Linux mainline works. It tends to be
very iterative. Cycles tend to be fast. You will probably get review
comments within a couple of days of posting code. You often see
developers posting a new version within a few days, maybe a week. If
reviewers have asked for large changes, it can take longer, but
general, the cycles are short.

When you say you need three weeks for internal review, that to me
seems very slow. Is it so hard to get access to internal reviewers? Do
you have a very formal review process? More waterfall than iterative
development? I would suggest you try to keep your internal reviews
fast and low overhead, because you will be doing it lots of times as
we iterate the framework.
Hi Andrew,

We understand your concern. We are working on this task with full focus. 
Initially there were some implementation change proposal from our 
internal reviewers to improve the performance and code quality. 
Consequently the testing of the new implementation took some while to 
bring it to a good shape.

Our internal reviewers Steen Hegelund and Horatiu Vultur are actively 
participating in reviewing my patches. I already have talked to them and 
we are in progress together to get the next version ready for the 
submission. We are trying our level best and working hard to push the 
next set of patches to the mainline as soon as possible.

Best regards,
Parthiban V
         Andrew
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help