Re: [PATCH net-next v2 5/9] net: ethernet: oa_tc6: implement internal PHY initialization
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-10-31 12:48:29
Also in:
linux-devicetree, linux-doc, lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-10-31 12:48:29
Also in:
linux-devicetree, linux-doc, lkml
quoted
quoted
+ tc6->mdiobus = mdiobus_alloc(); + if (!tc6->mdiobus) { + netdev_err(tc6->netdev, "MDIO bus alloc failed\n"); + return -ENODEV; + } + + tc6->mdiobus->phy_mask = ~(u32)BIT(1);Does the standard define this ? BIT(1), not BIT(0)?Ok, I think here is a typo. Will correct it.
There is still the open question, does the standard define this? If not, a vendor might decide to use some other address, not 0. So it might be better to not set a mask and scan the whole bus. phy_find_first() should then work, no matter what address it is using. Andrew