Thread (19 messages) 19 messages, 4 authors, 2024-02-06

Re: [PATCH v2 2/7] dt-bindings: can: mpfs: add missing required clock

From: Krzysztof Kozlowski <hidden>
Date: 2024-01-23 11:27:27
Also in: linux-can, linux-clk, linux-devicetree, linux-riscv, lkml

On 22/01/2024 13:19, Conor Dooley wrote:
From: Conor Dooley <conor.dooley@microchip.com>

The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a
CAN bus clock. The bus clock was omitted when the binding was written,
but is required for operation. Make up for lost time and add it.

Cautionary tale in adding bindings without having implemented a real
user for them perhaps.

Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../devicetree/bindings/net/can/microchip,mpfs-can.yaml     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help