Thread (52 messages) 52 messages, 9 authors, 2023-11-27

Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver

From: Köry Maincent <kory.maincent@bootlin.com>
Date: 2023-11-17 11:22:46
Also in: linux-devicetree, linux-doc, lkml

Thanks for your review!

On Thu, 16 Nov 2023 23:41:55 +0100
Andrew Lunn [off-list ref] wrote:
quoted
+struct pd692x0_msg {
+	struct pd692x0_msg_content content;
+	u16 delay_recv;
+};  
quoted
+	if (msg->delay_recv)
+		msleep(msg->delay_recv);
+	else
+		msleep(30);  
quoted
+	if (msg->delay_recv)
+		msleep(msg->delay_recv);
+	else
+		msleep(30);  
quoted
+	if (msg->delay_recv)
+		msleep(msg->delay_recv);
+	else
+		msleep(30);
+  
As far as i can see with a quick search, nothing ever sets delay_recv?

	Andrew
In fact I wrote the driver taking into account that there are two commands (save
and restore) that need a different delay response. As currently we do not
support them I can indeed drop it for now and add it back when I will add their
support.

Regards,

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help