Thread (52 messages) 52 messages, 9 authors, 2023-11-27

Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver

From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-11-16 22:38:27
Also in: linux-devicetree, linux-doc, lkml

+static int pd692x0_send_msg(struct pd692x0_priv *priv, struct pd692x0_msg *msg)
+{
+	const struct i2c_client *client = priv->client;
+	int ret;
+
+	if (msg->content.key == PD692X0_KEY_CMD && priv->last_cmd_key) {
+		while (time_is_after_jiffies(msecs_to_jiffies(30) + priv->last_cmd_key_time))
+			usleep_range(1000, 2000);
That is a bit odd. Could you not just calculate how long a sleep is
needed, rather than loop?

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help