Re: [PATCH net-next v2 10/11] staging: qlge: devlink health: use retained error fmsg API

From
Jakub Kicinski <kuba@kernel.org>
Date
2023-10-19 14:43:06
Also in
lkml
Reply to
Benjamin Poirier, 2023-10-19
On Thu, 19 Oct 2023 10:28:03 -0400 Benjamin Poirier wrote:
quoted
Humpf. Unrelated to the set, when did qlge grow devlink support?!

Coiby, do you still use this HW?

It looks like the driver was moved to staging on account of being
old and unused, and expecting that we'll delete it. Clearly that's
not the case if people are adding devlink support, so should we
move it back?  
AFAIK this was done by Coiby as an exercise in kernel programming.
Improving the debugging dump facilities was one of the tasks in the TODO
file.

I moved the driver to staging because it had many problems and it had
been abandoned by the vendor. There might be some qlge users left but is
that reason enough to move the driver back to drivers/net/
if there is no one who is interested in doing more than checkpatch
fixes on the driver?
Staging is usually an area for code entering the kernel, not leaving.
We should either suffer with it under drivers/net/ or delete it,
as you say, nobody is working on significant improvements so having 
the driver in staging is serving no purpose.

How about we delete it completely, and if someone complains bring 
it back under drivers/net ?
Thread (24 messages) 24 messages, 6 authors, last reply 2023-10-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help