Re: [PATCH net-next v2 10/11] staging: qlge: devlink health: use retained error fmsg API

From
Jakub Kicinski <kuba@kernel.org>
Date
2023-10-18 01:15:51
Also in
lkml
Reply to
Przemek Kitszel, 2023-10-17
On Tue, 17 Oct 2023 12:53:40 +0200 Przemek Kitszel wrote:
Drop unneeded error checking.

devlink_fmsg_*() family of functions is now retaining errors,
so there is no need to check for them after each call.
Humpf. Unrelated to the set, when did qlge grow devlink support?!

Coiby, do you still use this HW?

It looks like the driver was moved to staging on account of being
old and unused, and expecting that we'll delete it. Clearly that's
not the case if people are adding devlink support, so should we
move it back?
Thread (24 messages) 24 messages, 6 authors, last reply 2023-10-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help