Re: [PATCH net-next v2 11/11] devlink: convert most of devlink_fmsg_*() to return void

From
Simon Horman <horms@kernel.org>
Date
2023-10-18 16:11:07
Also in
lkml
Reply to
Przemek Kitszel, 2023-10-17
On Tue, Oct 17, 2023 at 12:53:41PM +0200, Przemek Kitszel wrote:

...
quoted hunk ↗ jump to hunk
diff --git a/net/devlink/health.c b/net/devlink/health.c
index 3858a436598e..f4a6de576b6c 100644
--- a/net/devlink/health.c
+++ b/net/devlink/health.c
@@ -566,17 +566,15 @@ static int devlink_health_do_dump(struct devlink_health_reporter *reporter,
 	if (!reporter->dump_fmsg)
 		return -ENOMEM;
 
-	err = devlink_fmsg_obj_nest_start(reporter->dump_fmsg);
-	if (err)
-		goto dump_err;
+	devlink_fmsg_obj_nest_start(reporter->dump_fmsg);
 
 	err = reporter->ops->dump(reporter, reporter->dump_fmsg,
 				  priv_ctx, extack);
 	if (err)
 		goto dump_err;
 
-	err = devlink_fmsg_obj_nest_end(reporter->dump_fmsg);
-	if (err)
+	devlink_fmsg_obj_nest_end(reporter->dump_fmsg);
+	if (reporter->dump_fmsg->err)
Hi Przemek,

Smatch warns that err is not set to an error value here.
 		goto dump_err;
 
 	reporter->dump_ts = jiffies;
...
Thread (24 messages) 24 messages, 6 authors, last reply 2023-10-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help