Re: [PATCH net-next v7 0/5] Rust abstractions for network PHY drivers
From: Benno Lossin <hidden>
Date: 2023-10-28 11:42:00
Also in:
rust-for-linux
On 10/28/23 13:07, Miguel Ojeda wrote:
On Sat, Oct 28, 2023 at 12:55 AM Andrew Lunn [off-list ref] wrote:quoted
It should also be noted that 80, or 100, is not a strict limit. Being able to grep the kernel for strings is important. So the coding standard allows you to go passed this limit in order that you don't need to break a string. checkpatch understands this. I don't know if your automated tools support such exceptions.Not breaking string literals is the default behavior of `rustfmt` (and we use its default behavior). It is also definitely possible to turn off `rustfmt` locally, i.e. for particular "items" (e.g. a function, a block, a statement), rather than lines, which is very convenient. However, as far as I recall, we have never needed to disable it. I am sure it will eventually be needed somewhere, but what I am trying to say is that it works well enough that one can just use it.
We have it disabled on the `pub mod code` in error.rs line 20: https://elixir.bootlin.com/linux/latest/source/rust/kernel/error.rs#L20 -- Cheers, Benno