Re: [PATCH v7 net-next 00/18] Introducing P4TC
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-10-17 15:40:31
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-10-17 15:40:31
On Tue, 17 Oct 2023 11:27:36 -0400 Jamal Hadi Salim wrote:
quoted
patch-by-patch W=1 C=1 should be good enough to catch the problems.Thanks - this helps. We didnt pay good attention to https://www.kernel.org/doc/Documentation/process/maintainer-netdev.rst Only thing that is missing now is the mention of C=1 in the doc. Patch to the doc acceptable? Also a note about false positives in sparse output (there were a few in the warnings from the bot) would be apropos.
Um. Maybe.. Sparse generates more false positives than good warnings lately :( We'd have to add some extra info like "Note that sparse is known to generate false-positive warnings, if you think that the warning generated with C=1 is bogus, ignore it and note that fact in the commit message". I don't like documenting things which aren't clear-cut :( I'm pretty sure you have pure W=1 warnings here, too.