Re: [PATCH net-next v3 1/3] rust: core abstractions for network PHY drivers
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2023-10-09 15:11:54
Also in:
rust-for-linux
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2023-10-09 15:11:54
Also in:
rust-for-linux
On Mon, Oct 09, 2023 at 10:49:07PM +0900, FUJITA Tomonori wrote:
On Mon, 9 Oct 2023 14:59:19 +0200 Miguel Ojeda [off-list ref] wrote:quoted
A few nits I noticed. Please note that this is not really a full review, and that I recommend that other people like Wedson should take a look again and OK these abstractions before this is merged.We have about two weeks before the merge window opens? It would great if other people could review really soon. We can improve the abstractions after it's merged. This patchset doesn't add anything exported to users. This adds only one driver so the APIs can be fixed anytime.
There is no rush, or deadline here. Take the time to get it in proper shape first please. thanks, greg k-h