Thread (91 messages) 91 messages, 9 authors, 2023-10-14

Re: [PATCH net-next v3 3/3] net: phy: add Rust Asix PHY driver

From: FUJITA Tomonori <fujita.tomonori@gmail.com>
Date: 2023-10-09 11:41:07
Also in: rust-for-linux

On Mon, 9 Oct 2023 09:23:04 +0200
Jiri Pirko [off-list ref] wrote:
quoted
diff --git a/rust/uapi/uapi_helper.h b/rust/uapi/uapi_helper.h
index 301f5207f023..08f5e9334c9e 100644
--- a/rust/uapi/uapi_helper.h
+++ b/rust/uapi/uapi_helper.h
@@ -7,3 +7,5 @@
 */
#include <uapi/asm-generic/ioctl.h>
+#include <uapi/linux/mii.h>
+#include <uapi/linux/ethtool.h>
What is exactly the reason to change anything in uapi for phy driver?
Should be just kernel api implementation, no?
It doesn't change anything. Like the C PHY drivers do, Rust PHY
drivers use the defined values in header files in uapi like MII_*,
BMCR_*, etc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help